ruby-grape / grape / 36408636746

100%

master: 100%

Pull #3013

github

Read a header version holding a hyphen whole

The header versioner parses `application/vnd.<vendor>-<version>+<format>`
with one pattern for every vendor. A hyphen can end either the vendor or
the version, so the pattern keeps hyphens out of the version. A dated
version such as `2024-06-20` (or `2.0-beta`) then split at its last
hyphen: `version` answered "20" and `env['api.vendor']` "acme-2024-06".
The request still reached the right version, because the whole media
type is matched against the declared ones, but everything reading the
parsed parts was wrong. An undeclared version of that shape was also
reported as an unknown vendor.

The versioner knows its vendor, so `MediaType.parse` and `.best_quality`
now take it: with the vendor spelled out, everything after it up to the
format is the version, hyphens included. A media type naming another
vendor is parsed as before. The per-vendor pattern lives in a
Grape::Util::Cache keyed by the vendors APIs declare, not by what
clients send.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1500 of 1500 branches covered (100.0%)

Branch coverage included in aggregate %.

22 of 22 new or added lines in 2 files covered. (100.0%)

4327 of 4327 relevant lines covered (100.0%)

29197.77 hits per line