PHPOffice / PHPPresentation / 36403780975

94%

push

github

ODPresentation Reader : Read a chart, and fix three things the Writer wrote wrong (#1021)

* ODPresentation Writer : Let the application colour a serie given no outline

A serie of a line, a radar or a scatter chart given no outline was written
with the stroke colour #4a7ebb, so every serie of the chart was drawn in the
same blue and none could be told apart. The PowerPoint2007 Writer says
nothing about the colour in that case, and the application picks one for
each serie; the ODPresentation Writer now does the same.

* ODPresentation Writer : Place a pie's data point by its position, and write the minor unit as a divisor

A pie wrote one chart:data-point per data point given a style of its own, one after the other from
the first, so the style of the third slice was put on the first and the third kept the serie's. A
data point is placed by its position in the serie for a pie as much as for a bar, so every chart
now writes the run of points taking the serie's style as one repeated chart:data-point.

chart:interval-minor-divisor is the number of minor intervals in a major one, not the size of a
minor one: a minor unit of 2 on a major unit of 10 is a divisor of 5. It is written only when both
units are set, since there is nothing to divide otherwise.

* ODPresentation Reader : Read a chart

A chart was written into its own object and never read back, so a presentation holding one loaded
without it -- or, for a file LibreOffice wrote, with the picture of the chart LibreOffice keeps
next to it as a plain drawing.

The Reader now reads the draw:object of a frame when it is a chart, before the picture next to it:
its type out of chart:class and the plot area's style (3D, vertical, stacked, percentage, smooth),
its series out of the local table (the values keyed by chart:domain for a scatter, by the
categories otherwise), the title, the legend, the blanks, both axes with their bounds, units,
gridlines, outline and fonts, and the fill, outline, marker, labels ... (continued)

328 of 346 new or added lines in 2 files covered. (94.8%)

11856 of 12558 relevant lines covered (94.41%)

84.45 hits per line