elixir-mint / mint / 2ec8b696b5475ecbdaa87c0098957bca339e17c0

91%

push

github

Merge commit from fork

* Use chunked framing only when chunked is the final transfer coding

RFC 9112 section 6.3 defines the response body length by the last coding
in Transfer-Encoding: chunked framing when chunked is final, otherwise
read until the connection closes. The first coding was checked instead, so
"gzip, chunked" was read until close and swallowed pipelined responses,
while "chunked, gzip" was parsed as chunked.

* Close the connection after an HTTP/1.0 response with Transfer-Encoding

RFC 9112 6.1 makes a recipient treat the framing of an HTTP/1.0 message
with Transfer-Encoding as faulty and close the connection after it. Mint
kept the connection open when such a response had Connection: keep-alive,
so bytes after its chunked body were parsed as the response to the next
pipelined request. Requests queued behind it now get a closed error.

* Close the connection after an HTTP/1.0 1xx response with Transfer-Encoding

The connection was only closed after a final HTTP/1.0 response with
Transfer-Encoding, which includes 101. Other informational responses went
on to parse the bytes after them, so those bytes were delivered as the final
responses to the current and queued requests. The connection is now closed
after such a 1xx response without processing what follows, and those
requests fail with a closed error.

Also test that Transfer-Encoding fields are combined before the final coding
is picked, and that an HTTP/1.0 keep-alive response with Content-Length
keeps the connection open.

5 of 5 new or added lines in 1 file covered. (100.0%)

1783 of 1970 relevant lines covered (90.51%)

716.86 hits per line