Eyevinn / mp4ff / 36384879883

83%

push

github

feat(mp4): add brand constants and share one ftyp/styp implementation

Add constants for the ftyp/styp brands defined in ISO/IEC 14496-12:2026 Annex E, 14496-14, 14496-15, CMAF 23000-19:2024 with Amd 1, DASH 23009-1 and codec specifications, as a first step for #540. A test parses brands.go and checks that each brand has four characters, is defined once, and is named Brand + brand.

FtypBox and StypBox had identical code. Both now embed an unexported generalTypeBox, mirroring the GeneralTypeBox class that 14496-12:2026 Section 5.2 defines for ftyp, styp, ttyp and brnd. The exported types, their methods and the encoded bytes are unchanged, and godoc still lists the promoted methods on each type. The shared code adds HasCompatibleBrand.

DecodeFtypSR and DecodeStypSR now return a nil box together with a read error, instead of a partly read box.

Refs #540

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017q3eYmMQXKrP3iY8UCS48r

82 of 86 new or added lines in 3 files covered. (95.35%)

22481 of 27296 relevant lines covered (82.36%)

0.82 hits per line