cameri / nats-server / 36379564149
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.66% (-0.04%) from 81.697%
36379564149

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

70581 of 86433 relevant lines covered (81.66%)

333924.44 hits per line

Coverage Regressions

Lines Coverage ∆ File
53
82.77
-0.23% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
22
77.91
-0.46% src/github.com/nats-io/nats-server/server/raft.go
8
92.47
-0.19% src/github.com/nats-io/nats-server/server/client.go
7
93.43
-0.34% src/github.com/nats-io/nats-server/server/gateway.go
7
86.11
-0.03% src/github.com/nats-io/nats-server/server/stream.go
5
86.09
-0.03% src/github.com/nats-io/nats-server/server/accounts.go
5
87.91
0.33% src/github.com/nats-io/nats-server/server/consumer.go
5
85.02
-0.25% src/github.com/nats-io/nats-server/server/events.go
5
86.52
-0.07% src/github.com/nats-io/nats-server/server/monitor.go
5
89.7
-1.07% src/github.com/nats-io/nats-server/server/msgtrace.go
4
88.53
-0.11% src/github.com/nats-io/nats-server/server/mqtt.go
2
80.96
-0.48% src/github.com/nats-io/nats-server/server/avl/seqset.go
2
64.0
0.02% src/github.com/nats-io/nats-server/server/opts.go
2
88.45
-0.07% src/github.com/nats-io/nats-server/server/server.go
1
89.44
0.13% src/github.com/nats-io/nats-server/server/leafnode.go
1
81.33
-0.05% src/github.com/nats-io/nats-server/server/memstore.go
Jobs
ID Job ID Ran Files Coverage
1 36379564149.1 66
81.66
GitHub Action Run
Source Files on build 36379564149