cameri / nats-server / 36295354253
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.697% (-0.06%) from 81.755%
36295354253

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

70613 of 86433 relevant lines covered (81.7%)

331066.23 hits per line

Coverage Regressions

Lines Coverage ∆ File
62
78.09
 -0.56% src/github.com/nats-io/nats-server/server/filestore.go
51
78.37
 -0.89% src/github.com/nats-io/nats-server/server/raft.go
14
73.77
 -0.2% src/github.com/nats-io/nats-server/server/jetstream_api.go
13
86.12
 -0.32% src/github.com/nats-io/nats-server/server/accounts.go
10
83.0
 0.17% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
6
63.97
 0.1% src/github.com/nats-io/nats-server/server/opts.go
4
87.58
 0.02% src/github.com/nats-io/nats-server/server/consumer.go
4
85.28
 0.05% src/github.com/nats-io/nats-server/server/events.go
2
84.39
 -0.1% src/github.com/nats-io/nats-server/server/jetstream.go
2
86.59
 0.11% src/github.com/nats-io/nats-server/server/monitor.go
2
84.59
 -0.09% src/github.com/nats-io/nats-server/server/route.go
2
86.14
 0.14% src/github.com/nats-io/nats-server/server/stream.go
Jobs
ID Job ID Ran Files Coverage
1 36295354253.1 66
81.7
 GitHub Action Run
Source Files on build 36295354253