orneryd / NornicDB / 36377207266

87%

Build Type

push

github

Committed by orneryd

Commit Message

fix(cypher): Neo4j 5 statement framing — CYPHER preamble and FINISH

accepted Nornic clause starts, so Neo4j 5 statement frames were rejected
and EXPLAIN PROFILE was accepted.

- CYPHER preamble: any number of leading `CYPHER [version] [option=value
  ...]` groups are stripped and the statement they precede runs, on every
  route (`CYPHER 5 RETURN 1`, `CYPHER runtime=slotted RETURN 1`, repeated
  groups, lowercase). A preamble with no statement stays a SyntaxError.
- FINISH terminator: a trailing FINISH (after a reading/writing clause,
  on every UNION branch, and inside CALL { } bodies via executeInternal)
  runs the statement and returns no rows, as Neo4j 5.19+. FINISH after
  RETURN/WITH/YIELD stays a SyntaxError; quoted 'FINISH' is a value.
- EXPLAIN PROFILE / PROFILE EXPLAIN are now a SyntaxError.

Coverage: TestCypherPreambleRunsTheStatement,
TestExplainProfileConflictRejected, TestFinishTerminatorReturnsNoRows.
Full pkg/cypher suite green (41.2s), pkg/server green (109s), TCK
ratchet 7794/7794, new tests pass twice under -race.

Benchmarks (M2 Max, BenchmarkStatementRouting simple_match_limit):
autocommit 17.2-17.3 us/op, 11246 B, 161 allocs; explicit tx
11.06-11.34 us/op, 5679 B, 88 allocs — allocation-identical to the
recorded band (16.4-17.6 / 10.4-11.1 us, 160-163 / 87-90 allocs).

Coverage Stats

187 of 202 new or added lines in 4 files covered. (92.57%)

18 existing lines in 7 files now uncovered.

175599 of 201915 relevant lines covered (86.97%)

1.02 hits per line