vektah / gqlparser / 1010

87%

master: 87%

Pull #471

circleci

Make MaxIntrospectionDepth linear in fragment spreads

checkDepthFragmentSpread followed every path through fragment spreads.
visitedFragments stops cycles, but not a fragment reached again through
another path, so a document in which each fragment spreads the next one
twice was walked 2^n times. With the default rules, a 1.1 KB document of
24 fragments took 2.5 s to validate, and each added fragment doubled
that. The rule runs whenever a document selects __schema or __type,
whether or not the server serves introspection.

Memoize each fragment's result by (name, depth at entry), which is all
the result depends on. The cycle guard and the message are unchanged.
The new tests fail on master: one times out, and the other fails if the
memo is keyed by name alone.

37 of 37 new or added lines in 1 file covered. (100.0%)

5399 of 6171 relevant lines covered (87.49%)

1.01 hits per line