zopefoundation / Products.CMFCore / 36353204373

87%

master: 87%

Build Type

Pull #161

github

Committed by mamico

Commit Message

Reindex all indexes on move, except contextless_indexes

Invert the default of the move optimization: every catalog index is now
treated as context-aware and reindexed when an object moves. Indexes
whose value does not depend on the location or security context can be
listed in the optional ``contextless_indexes`` lines property of
``portal_catalog`` (settable from GenericSetup ``catalog.xml``) to be
skipped. ``IContextAwareIndexProvider`` and its default utilities are
removed.

``moveObject(object, old_path)`` no longer takes ``idxs`` and returns
whether the move was handled. It is optional: catalogs that do not
provide it keep the unindex + index flow. ``CatalogTool.moveObject``
also updates the modification date, so alternative catalogs stay in
control of it.

Fix duplicate catalog entries when a reindex is pending at move time:
the queue was processed inside ``moveObject`` after the rename, so the
pending operation cataloged the object at the new path and the remap
orphaned that entry. The queue is now flushed on
``IObjectWillBeMovedEvent``, while queued objects still report their
old path. A leftover entry at the new path is dropped before the remap.

Pull Request Pull Request #161: Optimize object moves by reindexing only context-aware indexes

Coverage Stats

1966 of 3066 branches covered (64.12%)

Branch coverage included in aggregate %.

240 of 241 new or added lines in 6 files covered. (99.59%)

12 existing lines in 2 files now uncovered.

17851 of 19750 relevant lines covered (90.38%)

0.9 hits per line