zopefoundation / Products.CMFCore

87%

master: 87%

LAST BUILD ON BRANCH move_optimization

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 2.4.0
• 2.4.0b5
• 2.4.0b6
• 2.4.0b7
• 2.4.0b8
• 2.4.2
• 2.4.3
• 2.4.4
• 2.4.5
• 2.4.6
• 2.4.7
• 2.4.8
• 2.5.2
• 2.5.3
• 2.5.4
• 2.6.0
• 2.7.0
• 2.7.1
• 2.x
• 3.0
• 3.1
• 3.2
• 3.4
• 3.5
• 3.6
• 3.8
• 58-backport-collective-indexing-patch
• 58-backport-collective-indexing-patch-2
• Handle_Ripped_out_ZServer_support
• adjust-imports
• code-cleaup-keys
• config-with-zope-product
• config-with-zope-product-template-446e9797
• config-with-zope-product-template-4ec95046
• config-with-zope-product-template-7cab96bb
• config-with-zope-product-template-80e3d605
• config-with-zope-product-template-9fcd3d67
• config-with-zope-product-template-b21fbbf2
• config-with-zope-product-template-b3663390
• config-with-zope-product-template-e07f139c
• dataflake/issue_109
• dataflake/issue_112
• drop-pkg-resources-usage
• explicitacquisition
• fix-79
• fix-87
• fix-Products.DCWorkflow-dependency
• fix-Zope-4.3
• fix-broken-link-in-changes
• fix-deprecations
• fix-ensure-site-during-queue-processing
• fix-indexing-queue
• fix-isort
• fix-lint
• fix-lint-tests
• fix-processqueue-reindexsecurity
• fix-sphinx-8
• fix-tests/Products.GenericSetup
• fix-usage-of-subscribers.zcml
• fix-warnings
• fix/treewalk-reindexObjectSecurity
• fix_contentexport_in_py3
• fix_cookie_test#120
• gforcada-patch-1
• issue-140-optimize-deleteLocalRoles
• issue-90-test-subscribers
• issue_76
• issue_84
• issue_85
• jens_fix_51
• locales
• master
• maurits-decodeFilter-2x
• maurits-registerclass-resources
• maurits-release-3.3
• maurits-release-39
• move_optimization
• py3-im-self-2
• py37
• release-37
• revert-treewalk
• test-zope5
• thet/adapter-instead-adapts
• update-isort
• zcatalog-dependency
• zmi_customize_item

Build # 36355835503

Build Type

Pull #161

github

Committed by mamico

Commit Message

Do not acquire moveObject from the catalog's container

The check for an optional ``moveObject`` on the catalog used a plain
``getattr``.  In Plone the ``ICatalogTool`` utility is wrapped in the
site, so a catalog without ``moveObject`` acquired the one of
``plone.folder`` (``moveObject(id, position)``) and every move failed.
Check ``aq_base(catalog)`` instead.

Pull Request Pull Request #161: Optimize object moves by reindexing only context-aware indexes

Coverage Stats

1966 of 3066 branches covered (64.12%)

Branch coverage included in aggregate %.

253 of 253 new or added lines in 6 files covered. (100.0%)

17863 of 19762 relevant lines covered (90.39%)

0.9 hits per line