elixir-mint / mint / e159932671963178bee515fadf49b05d4c6a5af6

91%

push

github

Validate HTTP/2 response semantics (#518)

* Report incomplete HTTP/2 responses on RST_STREAM with NO_ERROR

Streams are removed as soon as the server ends them with END_STREAM, so
a RST_STREAM frame on a stream still being tracked means the response
is incomplete. With the NO_ERROR code it was reported as {:done, ref},
both before any headers and in the middle of a body with a declared
content-length. It now produces {:server_closed_request, :no_error}.

* Reject HTTP/2 responses with connection-specific headers or unsupported status codes

RFC 9113 8.2.2 makes a message containing connection, keep-alive,
proxy-connection, transfer-encoding or upgrade malformed, which is a
stream error. The te header is only allowed in requests, so it's
rejected in responses and trailers as well.

A :status of 101 is not supported in HTTP/2 (RFC 9113 8.6) and used to
be delivered as an interim response, and :status values below 100 were
accepted although HTTP/1 rejects them; both are now stream errors.

10 of 10 new or added lines in 1 file covered. (100.0%)

1699 of 1895 relevant lines covered (89.66%)

655.13 hits per line