Rotorsoft / act-root / 36345368888

100%

push

github

fix(act): park the correlate scan only on a short page (#1680)

* fix(act): park the correlate scan only on a short page

The disarm meant "this scan resolved no target", which reads as "the log
has nothing more for us" only for an unbounded scan. Every caller passes
a limit (app.correlate 10, settle 100, the poller 100), and most domain
events carry no reactions, so a full window of inert events was
indistinguishable from an empty log. The scan parked with a backlog still
ahead of its checkpoint, and the armed guard then returned without a
store read, so the reaction never ran, nothing was blocked, and settle
reported a clean catch-up.

The scan now counts what it read and parks only when the page came back
short, which is the only evidence it has of reaching the end of the log.
A page that fills its window stays armed and the next pass continues from
the new checkpoint. An unbounded page always qualifies, preserving the
one shape the old reasoning was correct for.

settle.ts already counted a cursor advance as progress specifically to
survive "a bounded correlate window full of inert events", but the extra
pass it bought hit the disarmed check and read nothing, so the loop broke
on the condition the guard was written to survive.

Documents the park rule in correlation-and-drain.md, which never
described it, and pins all three halves with behavior-contract rows.

Closes #1669

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(act): simplify the correlate park to a single expression

`found === query.limit` replaces the counter comparison against a
`?? Infinity` fallback. An unbounded page never matches, so it parks
exactly as the explicit fallback did, and dropping the `??` removes a
branch (coverage branch count 4357 to 4353). Trims the surrounding
comments to the non-obvious part.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(act): read the scanned count from query's return value

`Stor... (continued)

4353 of 4353 branches covered (100.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

9419 of 9419 relevant lines covered (100.0%)

1192.62 hits per line