elixir-mint / mint / f5fced56ff5aeb3b59b616f125a22afef4928146

91%

push

github

Bracket IPv6 literal hostnames in the Host header and :authority (#514)

* Bracket IPv6 literal hostnames in the Host header and :authority

Connecting with an IPv6 literal hostname produced "host: ::1:8080" and
the same :authority pseudo-header in HTTP/2. RFC 9112 3.2.2 and RFC 3986
3.2.2 require the literal to be enclosed in square brackets.

* Bracket IPv6 literal origins in the Host header sent through an HTTP proxy

Mint.UnsafeProxy adds its own Host header for the origin before passing
the request to Mint.HTTP1, so an IPv6 literal origin was still sent as
"host: ::1:8080" there.

* Leave the zone ID out of bracketed IPv6 literal hosts

:inet.parse_ipv6strict_address/1 accepts a zone ID, so "fe80::1%eth0"
was sent as "host: [fe80::1%eth0]:8080". The IP-literal grammar of
RFC 3986 3.2.2 that the Host header and :authority use has no zone ID,
so only the address is sent.

* Leave the zone ID out of IPv6 literals in proxy request targets

An IPv6 origin with a zone ID was still written with it into the
absolute-form request target sent to an HTTP proxy and into the CONNECT
request target and Host header, where the request target validation
rejected it. Both now use the address without the zone ID, like the Host
header and :authority already did.

17 of 17 new or added lines in 5 files covered. (100.0%)

1673 of 1870 relevant lines covered (89.47%)

662.3 hits per line