hyperledger-labs / fabric-smart-client / 36319533740

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): guard remaining unsafe protobuf field accesses (#1906)

Replace direct pointer-field dereferences with nil-safe Get*() accessors
(or an explicit nil guard, matching each file's existing sibling style)
so a malformed or partially-populated protobuf message is reported as
an error instead of panicking:

- chaincode/invoke.go: ProposalResponse.Response
- rwset/loader.go and fabricx/ledger.go and fabricx/transaction/envelope.go:
  Payload.Header
- generic/transaction/envelope.go: Payload.Header (explicit guard)
- protoutil/txutils.go: ProposalResponse.Response

Add regression tests for each fix, and fix a pre-existing assertion in
chaincode_test.go that expected a non-empty txID on a Submit() failure
path that always returns "".

Part of #1861

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Said Altury <109276519+SaidAltury-ibm@users.noreply.github.com>

Coverage Stats

10 of 10 new or added lines in 6 files covered. (100.0%)

11 existing lines in 4 files now uncovered.

27777 of 32106 relevant lines covered (86.52%)

2693.37 hits per line