avito-tech / go-transaction-manager / 36268429183
94%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 44
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.705% (-0.1%) from 93.809%
36268429183

push

github

web-flow 
refactor: Issue #181 (#182)

* refactored duplicate methods into savepoint.go

* fix(drivers): remove stale savepoint counter test broken by the dedup

TestTransaction_SavepointID_Consistency in drivers/sql and drivers/sqlx
referenced the private saves/incrementID/decrementID members that the
savepoint-counter dedup replaced with drivers.SavePointCounter, so both
packages failed to compile. The same behavior (including concurrency)
is already covered by trm/drivers/savepoint_test.go.

* docs(drivers): fix DecrementID's doc comment

It returns the identifier of the savepoint being released or rolled
back (the pre-decrement value), not "the current savepoint identifier"
as previously worded, which read as post-decrement.

* docs(changelog): describe sqlx's dropped ErrNestedBegin wrapping

sqlx.Transaction.Begin stopped wrapping failed savepoint creation with
trm.ErrNestedBegin (#178), aligning it with sql/pgxv4/pgxv5, but the
change never got a CHANGELOG entry. Direct (non-Manager) callers of the
sqlx driver checking errors.Is(err, trm.ErrNestedBegin) on Begin should
know their error contract changed.

* fix: unbreak CI compilation for sql/sqlx drivers

Uncomments the `replace` directives in `drivers/sql` and `drivers/sqlx`
to map `trm/v2` to the local repository filesystem. This resolves the
'undefined: drivers.SavePointCounter' compilation errors in the GitHub pipeline.

* fix(drivers): drop local trm replace directives from sql/sqlx go.mod

The root go.work workspace already resolves trm/v2 to the local ./trm
checkout for every build/test run from within a driver directory, so
the replace directive committed to unbreak CI was redundant, and it
would have broken `go get` for consumers building a driver outside the
workspace. Document the workspace resolution in the README so this
isn't rediscovered as a "CI is broken" issue again.

Addresses review threads PRRT_kwDOH9yLyM6mSVu_ and PRRT_kwDOH9yLyM6mSWBq.

* chore: add missing go.work.sum entry for go-... (continued)

1563 of 1668 relevant lines covered (93.71%)

12.16 hits per line

Jobs
ID Job ID Ran Files Coverage
1 36268429183.1 44
93.71
GitHub Action Run
Source Files on build 36268429183