ruby-grape / grape / 36250040651

100%

master: 100%

Pull #3011

github

Reject a number with a fractional part for an Integer param

dry-types turns a number into an Integer with Kernel#Integer, which
truncates. So a JSON body's `{"quantity": 2.99}` passed
`requires :quantity, type: Integer` as 2, and -0.5 became 0, while the
same value sent as a string ("2.99" in a query) was rejected. The
truncation also reached Array[Integer] and Set[Integer] elements, let
`values: 1..10` accept 1.5 as 1, and made `types: [Integer, Float]` answer
2 for a JSON 2.99 but 2.99 for the query string, because the Integer
member never failed and the Float member never got a turn.

PrimitiveCoercer now refuses a real number with a fractional part when
the declared type is Integer. A whole number such as 1.0 still becomes 1,
so nothing that was coerced without loss changes.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1496 of 1496 branches covered (100.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

4318 of 4318 relevant lines covered (100.0%)

29224.29 hits per line