ruby-grape / grape / 36249889184

100%

master: 100%

Build Type

Pull #3010

github

Committed by ericproulx

Commit Message

Reject nil for a required param with values in a nested scope

A `requires` param with `values:` rejected `nil` only at the root scope.
In a Hash scope, an Array scope or a `given` block, `nil` (or a value
that coerces to it, such as `""` for `type: Integer`) passed validation
and reached the endpoint, so `{"lines":[{"qty":null}]}` got through
`requires :qty, type: Integer, values: 1..99` and broke code as ordinary
as `params[:lines].sum { |line| line[:qty] }`. The README says the
opposite: "`requires` enforces presence and `:values` rejects `nil`."

The root-only rule came from f60eaa62 (2014, #671). Back then a child
scope's validators ran even when its optional parent was absent, so
rejecting `nil` there failed every request that left the parent out.
Scopes now skip validation when an optional parent is absent, so the
workaround only let `nil` through where the parent *is* given.

The validator now rejects `nil` whenever the param is required. A
missing nested param also reports `does not have a valid value` after
`is missing`, as a root param already did.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Pull Request Pull Request #3010: Reject nil for a required param with values in a nested scope

Coverage Stats

1491 of 1491 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

4308 of 4309 relevant lines covered (99.98%)

29440.05 hits per line