36240638299
94%

Ran 26 Sep 2026 12:04PM UTC

Jobs 1

Files 43

Run time 1min

Badge

Embed ▾

Committed 26 Sep 2026 12:01PM UTC coverage: 93.75% (+0.1%) from 93.616%

Build # 36240638299

Build Type

push

github

Committed by

web-flow

Commit Message

fix: prevent context leak on error (#174)

* fix: prevent context leak on error

* docs(manager): state that Init cancels the derived context on error

Also assert the returned context is non-nil before reading its Err in
the cancel-on-error tests, so a factory that returns a nil context fails
with a clear message instead of a nil pointer dereference.

* fix(manager): keep Init minimal and cover every cancel-on-error path

- UnSkippable is back to comparing with ErrSkip directly: errors.Is dropped
  a wrapped leaf together with its message, and it is unrelated to the leak.
- Only err is a named result; the cancel != nil guard is gone (withCancel
  never returns nil).
- The cancel-on-error test is a table over the four error paths: a failed
  Begin, ErrNestedBegin, ErrPropagationMandatory and ErrPropagationNever,
  with WithCancelable instead of a timeout.
- CHANGELOG entry under 2.0.4.

* style: satisfy wsl and unparam in the manager package

* test(trm): UnSkippable drops only the bare ErrSkip, a wrapped one is kept

* docs: move the Init context leak entry to 2.0.5

* test(trm): snake_case name for the UnSkippable case

---------

Co-authored-by: maranqz <ilia.sergunin@gmail.com>

Coverage Stats

1575 of 1680 relevant lines covered (93.75%)

11.03 hits per line

Coverage Regressions

Lines	Coverage	∆	File
1	93.94	2.36%	trm/v2/manager/manager.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	36240638299.1	26 Sep 2026 12:04PM UTC	43	93.75	GitHub Action Run

avito-tech / go-transaction-manager / 36240638299
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36240638299

avito-tech / go-transaction-manager / 36240638299 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36240638299

avito-tech / go-transaction-manager / 36240638299
94%

README BADGES
x