kcl-lang / kcl-go / 36227370376

34%

Build Type

push

github

Committed by web-flow

Commit Message

feat(ast): align Go AST JSON with Rust source of truth (#600)

Bring the Go binding's AST struct definitions in pkg/ast in sync with the
serde JSON emitted by the Rust compiler in ../kcl/crates/ast/src/ast.rs.

Concretely:

- Drop `Module.Pkg`. Rust's Module struct has no `pkg` field, so the Go
  binding had no business exposing one.
- Fix NumberLit/StringLit/NameConstantLit discriminators on the
  `NewNumberLit`/`NewStringLit`/`NewNameConstantLit` constructors from
  `"Number"`/`"String"`/`"NameConstant"` (the inner Literal-enum form) to
  `"NumberLit"`/`"StringLit"`/`"NameConstantLit"` (the Expr-enum form that
  crosses the wire). The unmarshaller in pkg/ast/json.go already expects
  the long form on input, so this just fixes the constructors' output.
- Add `ConfigEntry.IsShorthand`. Rust's ConfigEntry has
  `is_shorthand: bool` with `#[serde(default, skip_serializing_if = ...)]`;
  the Go struct was missing it entirely.

Decorator and SchemaConfig are deliberately kept as separate DTOs rather
than being retyped to the polymorphic CallExpr/SchemaExpr forms. When a
CallExpr or SchemaExpr appears nested under NodeRef<T> (e.g. inside
SchemaStmt.decorators or UnificationStmt.value), the wire JSON does not
carry the `"type":"Call"` / `"type":"Schema"` discriminator — it is the
flat `{func,args,keywords}` / `{name,args,kwargs,config}` shape — so
encoding/json cannot resolve the polymorphic variant. This matches the
Java binding's existing design and is documented in
https://github.com/kcl-lang/lib/blob/main/AST_DRIFT.md (note A).

Add `pkg/parser/ast_alignment_test.go` which parses a real KCL fixture
through `parser.ParseFile` and verifies the JSON round-trips into the Go
AST structs. This is the Go equivalent of the Java
`AstJsonAlignmentTest`.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Coverage Stats

0 of 7 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

4989 of 16624 relevant lines covered (30.01%)

2.06 hits per line