railsadminteam / rails_admin / 36216335211

96%

master: 96%

push

github

Let any callable serve as asset_source, and show what it is for

The callable asset_source only ever accepted a Proc - both the resolver and
the layout tested for one - while the documentation promised anything
responding to `call`. Passing an object with a #call raised "Unknown
config.asset_source". Widen both to respond_to?(:call); an application that
wants this logic in a class of its own should not have to wrap it in a lambda.

Nothing rendered through the callable in the suite, so cover that too, and
note in the docs that a bare String comes back HTML-escaped - the helpers
return safe markup, hand-built strings do not.

The point of the callable is the bundlers RailsAdmin stopped naming, so write
up Vite, checked against a fresh application: its generated stylesheet also
needs $fa-font-path moved to the npm package, since that defaults to the asset
path where the gem keeps the Font Awesome face, Vite serves from its own
output directory, and every icon silently 404s.

Import maps get a pointer rather than a procedure. Reaching RailsAdmin's
modules that way still works - verified against a fresh application, through
jspm-resolved pins the way 3.x generated them - but the pins are the
application's to maintain, and a recipe here would be one more thing to keep
current.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 of 1 new or added line in 1 file covered. (100.0%)

4306 of 4473 relevant lines covered (96.27%)

277605.95 hits per line