railsadminteam / rails_admin / 36142350556

96%

master: 96%

Build Type

push

github

Committed by mshibuya

Commit Message

Put the :external stylesheet where a JS build will not eat it

rails_admin.scss was generated into app/javascript, which is the directory
jsbundling-rails hands to esbuild as JavaScript - its build script globs
app/javascript/*.*. Installing RailsAdmin therefore broke the application's
own build on the spot:

  ERROR: No loader is configured for ".scss" files: app/javascript/rails_admin.scss

and application.js stopped being emitted along with it. Generate it into
app/assets/stylesheets, where it lived before 4.0 and where a CSS bundler
looks for it.

The printed instructions now point at the build scripts rather than at a bare
sass invocation. cssbundling-rails hooks `build:css` into assets:precompile,
so an entrypoint compiled only by hand works in development and then silently
goes missing on deploy; sass takes several input:output pairs, so it is one
more pair in the script the application already has.

Checked against a fresh `rails new -j esbuild -c sass`: the installer runs,
`npm run build` picks up rails_admin.js through the stock glob untouched, and
`assets:precompile` on its own produces app/assets/builds/rails_admin.css.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

4305 of 4472 relevant lines covered (96.27%)

272812.13 hits per line