36199461496
88%

Ran 25 Sep 2026 11:37PM UTC

Jobs 1

Files 980

Run time 3min

Badge

Embed ▾

Committed 25 Sep 2026 10:36PM UTC coverage: 88.119% (+0.02%) from 88.101%

Build # 36199461496

Build Type

push

github

Committed by

web-flow

Commit Message

Document that qk_target_add_instruction always consumes the entry (#17053)

The `@param` documentation for `target_entry` said only that "the pointer
gets freed when added to the ``QkTarget``", which reads as conditional on
the add succeeding.  It is not: `Box::from_raw` runs before the call to
`Target::add_instruction`, so the entry is freed on every return path
once the pointer check has passed, including when the instruction could
not be added.

A caller handling an error such as `QkExitCode_TargetInstAlreadyExists`
therefore had to read the Rust source to find out whether they still
owned the entry.  Guessing one way double frees; guessing the other
leaks.  This is reachable from ordinary use -- build a target, add the
same gate twice, handle the error, carry on -- and produced a
`free(): invalid size` abort in Qiskit.jl.

State the invariant instead: the function takes ownership of a valid
entry and frees it regardless of the returned `QkExitCode`.  The wording
follows the existing house style for ownership transfer used by
`qk_dag_to_python` and `qk_obs_to_python`, with one added clause for the
fact that this function is fallible and returns an exit code.

Documentation only; no behaviour change.

Fixes #17051.

Assisted-by: Claude Opus 5

Coverage Stats

122375 of 138875 relevant lines covered (88.12%)

944896.77 hits per line

Coverage Regressions

Lines	Coverage	∆	File
3	92.54	0.51%	crates/qasm2/src/lex.rs
1	90.32	0.0%	crates/circuit/src/parameter/parameter_expression.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	36199461496.1	25 Sep 2026 11:37PM UTC	980	88.12	GitHub Action Run

Qiskit / qiskit / 36199461496
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36199461496

Qiskit / qiskit / 36199461496 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36199461496

Qiskit / qiskit / 36199461496
88%

README BADGES
x