FlexMeasures / flexmeasures / 36192278468

86%

push

github

Feat: when copying assets, copy their automations, too (#2531)

* data/services: copy an asset subtree's automations, left inactive

Context:
- Issue #2528: copying an asset kept its sensor structure but dropped the
  recurring forecasts, schedules and reports that make it operational.

Change:
- Added `copy_automations`, which copies every automation on a copied asset onto
  the corresponding new asset, keeping its name, type, cron expression and
  timezone, but starting it inactive and with a fresh cursor, so it inherits
  neither the original's run history nor its queued jobs.
- References to sensors, assets, organisations and data sources are remapped by
  walking the marshmallow schema that describes the data generator's
  configuration and parameters, so the same code serves automation types and
  plugin generators beyond forecasts.
- A reference outside the copied subtree is kept only where the destination
  organisation may read it; otherwise the automation is skipped, as it is when
  its data generator is unavailable or the remapped configuration no longer
  validates.
- Each automation is copied inside its own savepoint, so a skipped one leaves
  behind neither a partial automation nor a stray generator data source, and the
  asset copy itself goes ahead regardless.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* api/v3_0: copy an asset's automations and report the ones left out

Context:
- Issue #2528: the copy endpoint duplicated assets and sensors only, so a copied
  site arrived without the automations that made it run.

Change:
- `copy_asset` now tracks the new asset IDs alongside the new sensor IDs, hands
  both to `copy_automations`, and returns an `AssetCopy` naming the copied asset
  and the automations that were skipped.
- `POST /assets/<id>/copy` reports those under a new `skipped_automations` field,
  each with its id, name, asset and reason, and says so in the message; the audit
  log record on the copy ... (continued)

204 of 252 new or added lines in 3 files covered. (80.95%)

20302 of 23593 relevant lines covered (86.05%)

0.86 hits per line