FlexMeasures / flexmeasures / 36191867000

86%

Build Type

push

github

Committed by web-flow

Commit Message

Support SQLAlchemy 2.1, upgrade dependencies, and show an error page on unexpected errors (#2596)

* Answer unexpected errors with a proper 500, instead of a broken status line

An exception that is not an HTTPException (e.g. a database error) went
through the same handling as HTTP errors. The HTML handler took its code
attribute as the response status, but SQLAlchemy errors carry codes like
"f405", so the response went out as "HTTP/1.1 0 f405". Behind a proxy,
browsers then reported ERR_HTTP2_PROTOCOL_ERROR (Chrome) or a failed
secure connection (Firefox), rather than showing our error page, and the
error was only visible in the logs.

Such exceptions are now logged in full as before, and then answered as an
InternalServerError: a 500 with our error page in HTML, and a 500 in
JSON. The response also no longer carries the exception's message, which
for a database error includes the SQL and its parameters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZsZTwYKqi3NBS2EfQVZMU
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Recognise forbidden belief replacements by SQLSTATE, whatever the driver

catch_timed_belief_replacements checked for psycopg2's UniqueViolation class, so on psycopg 3 (the driver SQLAlchemy 2.1 picks for a plain postgresql:// URI) a forbidden replacement got a generic 500 instead of its explanation. Both drivers report SQLSTATE 23505, psycopg2 as pgcode and psycopg 3 as sqlstate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZsZTwYKqi3NBS2EfQVZMU
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Connect through psycopg2 when the database URI names no driver

SQLAlchemy 2.1 connects a plain postgresql:// URI through psycopg 3 rather than psycopg2. psycopg 3 binds parameters on the server, which rejects comparisons FlexMeasures still makes, such as an integer id with an id string taken from a URL ("operator does not e... (continued)

Coverage Stats

65 of 85 new or added lines in 7 files covered. (76.47%)

3 existing lines in 2 files now uncovered.

20104 of 23349 relevant lines covered (86.1%)

0.86 hits per line