elixir-mint / mint / d9433e6262a1d8361e71d9255afd80c129500316-PR-515

89%

main: 91%

Pull #515

github

Keep the caller's :mode in forward-proxy mode

Since #494, the connection to the proxy in forward-proxy mode only gets
the options in the :proxy tuple. That connection is the one returned to
the caller, so a :mode given to Mint.HTTP.connect/4 was dropped and the
connection started in active mode. Callers asking for a passive
connection, such as Finch, then failed on the first recv/3.

The proxy connection now defaults to the caller's :mode, and a :mode in
the :proxy tuple still takes precedence.

1 of 1 new or added line in 1 file covered. (100.0%)

1585 of 1784 relevant lines covered (88.85%)

560.93 hits per line