safe-global / safe-client-gateway / 36115353196

89%

push

github

ci: retire the last transitional pieces of the staging cutover (#3489)

Two things existed only to keep the old deploy path alive while staging moved onto the new ArgoCD setup. That move finished on 2026-09-25 and both can go.

**The moving `:staging` tag.** It existed so argocd-image-updater on the legacy devstaging Application kept seeing a tag to watch. That Application was deleted at the cutover, so nothing in either cluster reads it. Staging now publishes only immutable tags; releases are untouched and still publish `vX.Y.Z` and `latest` to both registries, so anyone pulling the public Docker Hub image keeps working.

Removed from `_build-image.yml` entirely rather than just from the caller: `staging.yml` was its only user, `production.yml` does not use it, and safe-config-service's `_build-image.yml` has no such input at all — it was a CGW-specific addition for this transition. Dropping it takes the reusable back to parity with the reference implementation.

**The version gate.** It polls `/about` until it reports the tag the deploy just merged, proving the new pods are serving rather than the old ones. It was off because until the cutover the bump was inert and image-updater moved the cluster, so the step would have been reporting on a deploy it did not do. That bump is now the only thing that deploys staging.

The budget is the reusable's default, 40 polls at 15s. Staging runs 5 replicas behind a PDB with a 30s readinessProbe period and TypeORM migrations at boot, plus ArgoCD's sync interval, so 10 minutes should be enough — but it has never been measured end to end, and this is the change that measures it. If it is too tight the downside is bounded: `health_gate: false` means no ArgoCD wait and no rollback, so a timeout is a red job on a healthy staging. Raise it in `_deploy.yml` if the first runs come close, in safe-config-service first so the two stay identical.

/about, not /v1/about: AboutController declares no version and app.provider.ts... (continued)

4364 of 5135 branches covered (84.99%)

Branch coverage included in aggregate %.

11122 of 12221 relevant lines covered (91.01%)

514.64 hits per line