safe-global / safe-client-gateway / 36111420941

89%

push

github

ci: drop the legacy autodeploy nudge from the staging pipeline (#3488)

* ci: drop the legacy autodeploy nudge from the staging pipeline

The `notify-legacy-deploy` job posted a Docker-Hub-webhook-shaped payload to nudge the legacy controller into pulling the new `:staging` image. That controller no longer manages CGW: the devstaging Application and argocd-image-updater were retired at the 2026-09-25 cutover, and staging now renders from safe-client-gateway-infra-tf.

It was also never working. `scripts/autodeploy.sh` captured the HTTP status into `--write-out` and threw it away, and with `curl -s` and no `-f` curl exits 0 for any response, so `set -e` never saw a failure. The status check added when PR #3474 was reviewed made it visible on the first run: **HTTP 404**. The webhook had been rejecting every nudge, silently, for however long — which means argocd-image-updater's polling had been doing all the work on its own.

So the job is now a no-op that paints a red cross on every Staging run. Removed, along with the script. `AUTODEPLOY_URL` and `AUTODEPLOY_TOKEN` have no remaining reader and can be revoked (WA-3432).

The header comment is rewritten: it still described staging as deployed by the legacy path and the new Application as unapplied, both of which stopped being true at the cutover.

Two transitional pieces stay, each with its ticket named in the YAML:

  * `moving_tag: staging` (WA-3428). Nothing in the cluster consumes it now, but _build-image.yml publishes a moving tag to both registries and the Docker Hub one is public, so dropping it would also stop publishing safeglobal/safe-client-gateway-nest:staging. It waits on the external-consumer inventory.
  * `version_check_url: ""` (WA-3629). The poll runs after the deploy PR is merged, and that merge currently fails, so switching it on would change nothing. It waits until deploys merge and the timeout can be sized against a real rollout.

Verification: yarn format, yarn lint and yarn test c... (continued)

4365 of 5135 branches covered (85.0%)

Branch coverage included in aggregate %.

11122 of 12221 relevant lines covered (91.01%)

514.6 hits per line