hyperledger-labs / fabric-smart-client / 36111801377

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(vault): report an absent key from GetDirectState instead of dereferencing it (#1890)

GetDirectState returned vv.Raw without checking the *driver.VaultRead for
nil. A key absent from storage legitimately yields (nil, nil): the SQL
vault reader resolves GetState through collections.GetUnique, whose Next
hands back the zero pointer and a nil error once the iterator is
exhausted, so reading a missing key panicked.

Return a nil value and no error instead. That matches the two siblings
that already handle it, GetState under FromStorage in this same file and
the fabricx vault's GetDirectState, so the direct path no longer stands
alone.

The existing fake query executor always returns a populated read, which is
why no test reached this. Add one that reports every key as absent and
cover both paths so they stay aligned.

Fixes #1889

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

3 existing lines in 2 files now uncovered.

27745 of 32098 relevant lines covered (86.44%)

2337.38 hits per line