veeso / suppaftp / 36108814777

85%

push

github

fix: accept active-mode data connections only from the server (#181)

In active mode the client listened for the data connection and took
whichever one arrived first, only logging its address. Anyone able to
reach the listener could connect before the server and hand the client
a forged listing or download, or receive an upload meant for the server.

The sync, tokio and smol clients now accept the data connection only
from an address allowed by `ActivePeerCheck`. The default,
`ControlPeer`, accepts only the server on the control connection.
`Any` accepts every address, as before this check existed. `Allow`
accepts a list of addresses, for servers behind NAT that connect back
from another address, or control connections that go through a relay.

Call `set_active_peer_check` to change the default.

155 of 160 new or added lines in 5 files covered. (96.88%)

6808 of 8018 relevant lines covered (84.91%)

6711.68 hits per line