veeso / suppaftp / 35986456862

85%

push

github

fix: bound the size of control-connection replies (#179)

The reply reader used `read_until` without a byte limit, and a multiline
reply was gathered until its terminal line, so a server could make the
client buffer without bound, starting with the greeting before any
authentication. The same held for the continuation lines `feat` reads.

A reply may now take at most 256 KiB, every line included. Past that,
the sync, tokio and smol clients fail with `FtpError::ConnectionError`
holding the new public `ReplyTooLarge`, without reading further. The
async readers keep their cancellation safety: bytes already held from a
cancelled read count toward the same bound.

211 of 212 new or added lines in 7 files covered. (99.53%)

6552 of 7861 relevant lines covered (83.35%)

6839.62 hits per line