openconfig / kne / 36066937338

47%

Build Type

push

github

Committed by web-flow

Commit Message

Implement KNE Packet Bridge daemon and CLI subcommand (#762)

* Add packet bridge subcommand

The bridge subcommand sets up a daemon process that will forward
packets into / out of the KNE cluster over a gRPC streaming service.
An external client can use this service to inject or receive packets
to/from a particular interface defined in the topology.

* Set up docker builds for kne bridge

* Make a symmetric bridge client

This makes bridge usable in KNE-only situations, to link two separate
clusters (like if one cluster has access another doesn't.) More
importantly, it facilitates easy testing of the feature.

* Convenience make targets for Kind testing and release

* Default --logtostderr for bridge, since it's intended for K8s usage

* pre-review

* use a pool for packet buffers
* use cancel so waiting goroutines are freed if readLoop exits on a
  socket error
* use signal.NotifyContext()
* Make sure kne bridge runs root handlers
* distinguish between normal and unexpected stream closure in the client
* Better test coverage

* Lint fixes

* Lint fixes

* Add a comment to point out non-obvious side effect of service block

* Make sure the packet bridge service can be exposed as a node port service

* Add a release command for the packet bridge

* Fix lint warnings

* Re-run go generate

* Add support for ALTS authentication on the bridge service

* Be more permissive with pings because Borg is aggressive with them

* Use socat to get IPv6 into the single-stack K8s cluster

* Lint

* Use a daemonset for socat proxies

* Review comments:

  1. Netpoller Integration & Interruptible ReadPacket:
      • Refactored bridge.go:59 in bridge.go:69 to set the raw socket to non-blocking via unix.
      SetNonblock, wrap the file descriptor in os.NewFile, and use syscall.RawConn (s.rc.Read and s.rc.
      Write).
      • Calling s.Close() (s.f.Close()) now immediately interrupts any pending or concurrent ReadPacket()
      / WritePacket() calls via the Go runtim... (continued)

Coverage Stats

766 of 1082 new or added lines in 11 files covered. (70.79%)

1 existing line in 1 file now uncovered.

6837 of 14468 relevant lines covered (47.26%)

0.54 hits per line