ruby-grape / grape / 36054476266

100%

push

github

Stop copying the formatter and calling empty filter phases per request (#3004)

Three costs every request paid for nothing:

- Middleware::Formatter was copied per request by Base#call so that
  #before and #after could find the env and the app's response in ivars.
  It keeps no other request state, so its own #call! now passes the env
  along and #call answers from the one instance the stack built, without
  the copy. #before and #after are gone, and an error raised while
  formatting is still reported the way Base reports one from #after.
  Base's per-request readers (env, context, rack_request, query_params,
  response) are private on it, since that instance holds no request.
- Endpoint#run called run_filters for all five filter phases, and most
  endpoints register nothing for most of them. It now skips an empty one.
- Grape::API.call and Router::Route#call were Forwardable delegators,
  which check the target with defined? and forward through `...` on every
  call. Both run once per request, so they are written out.

The formatter spec read the per-request state back through a stubbed dup;
it now asserts on the env the middleware was handed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1498 of 1498 branches covered (100.0%)

Branch coverage included in aggregate %.

53 of 53 new or added lines in 5 files covered. (100.0%)

4336 of 4336 relevant lines covered (100.0%)

29147.83 hits per line