solidjs / solid / 36032140222

74%

main: 89%

push

github

fix(web): single-flight delivery is one shared path; frame transform reads consumer-keyed flight data (#3638) (#3640)

Single-flight mutations that revalidate a server component failed:
foldFlightData keys flight data by source ({ [source]: slice }, the
unnamed collector under "true") but frameTransformFlightResult scanned
only the top level for components, declined, and the plain codec threw
on the component function. The transform now scans each source's slice
one level down, frames component entries as regions addressed by their
call (bare functions by their key), and keeps the source keys.

Two more halves of the same drift (21a512202 updated server.ts/client.ts
and not the frames pair):

- The frames client handed the whole keyed envelope to the unnamed
  consumer only. Delivery is now one implementation in shared.ts
  (deliverFlightData + hasFlightMetadata) that both the plain client's
  dispatch and the frames client's applyFlightResponse call; the
  read-call exclusion stays in client.ts, no routing remains in
  frame-transport.ts.
- frameFlightResponse stamped a bare X-Single-Flight: true that won the
  header merge and dropped named sources. The fold owns the header on
  every body shape now.

ServerComponentHandlerOptions.consumer and .codec (@experimental) are
removed: they covered a two-copies-of-the-client bundling condition that
the frames build's externalizeSharedTransport rules out by construction
(verified in dist).

Size: the frames scenario carries +100 B (11384 -> 11484 B) because it
never retained the plain client's routing loop and now retains the
shared one; cap 11.45 -> 11.50 KB with a dated note. Neutral for an app
that bundles both transports.

Reported by @brenelz.

Closes #3638

Co-authored-by: Claude via Cursor <noreply@cursor.com>

606 of 894 branches covered (67.79%)

Branch coverage included in aggregate %.

883 of 1142 relevant lines covered (77.32%)

25.33 hits per line