solidjs / solid / 35964032397

74%

main: 89%

push

github

feat(signals): ABANDONED_FLIGHTS, FALLBACK_FLASH, STACKED_HOLDS as findings (#3608)

* feat(signals): ABANDONED_FLIGHTS, FALLBACK_FLASH, STACKED_HOLDS — the feedback-table facts as findings

`feedback()` already counted abandoned flights per source, fallback flashes
per boundary and holds per interaction, but only for a consumer that
imported the fold and read the tables. These are the same facts on the
diagnostics channel at a threshold, as they happen:

- ABANDONED_FLIGHTS (warn): one async source abandoned `count` flights in
  `windowMs` (3 / 1000ms), each superseded by the next before it landed —
  the request-per-keystroke signature. Once per window per source; the
  window lives in an engine WeakMap, not on the node.
- FALLBACK_FLASH (info): a Loading fallback displayed and hidden inside
  FALLBACK_FLASH_MS (150ms, now exported and shared with the fold), judged
  at hide on the same display clock the `fallback` record uses. The open
  is kept for the check even with no fold and no listener.
- STACKED_HOLDS (warn): `count` or more interactions (3) waiting in one
  hold when it commits — the person kept clicking or typing while the
  first answer was in the air. Counted over the open interactions at hold
  settle, before they are released.

Three options (`abandonedFlights`, `fallbackFlashes`, `stackedHolds`)
merged most-demanding like the rest; none is under `checks`, since these
are verdicts on records, not cost accounting.

Size: engine +756 B (cap 29.00 -> 29.80 KB); the tier moved 35 B with
byte-count-identical core artifacts — the package-wide property mangler
reassigns the core's short names whenever the engine's `_`-property usage
changes — noted as drift (cap 17.45 -> 17.50 KB).

Co-Authored-By: Claude via Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* chore(size): re-measure feedback findings at landing; engine cap 30.70 -> 31.45 KB

Co-authored-by: Claude via Cursor <noreply@cursor.com>

---------

Co... (continued)

606 of 894 branches covered (67.79%)

Branch coverage included in aggregate %.

883 of 1142 relevant lines covered (77.32%)

25.04 hits per line