solidjs / solid / 35962999490

74%

main: 89%

push

github

feat(signals): GRAPH_GROWTH — the live graph counted at navigation settle (#3619)

* feat(signals): GRAPH_GROWTH — the live graph counted at each navigation's settle

The leak class a heap snapshot finds, as a finding. At every navigation's
settle the engine counts the live graph and emits a `graph` record
(GraphEvent: at, owners, roots, route, navigation); when the count at the
same route has climbed on `visits` consecutive visits (3) to `ratio`× the
first (1.25), GRAPH_GROWTH names the route with the counts. The count is
the whole graph's, so the first route to complete its climb reports and
names the others seen; the verdict then resets for the graph.

The plan assumed the core kept node counters; it does not — the fan-in/out
numbers are per-walk locals. Rather than add a live counter (an increment
at every creation and disposal, on the idle observe path), the observe
core registers top-level roots weakly — `createOwner` with no parent adds
a WeakRef to a Set reaped by a FinalizationRegistry, disposal removes it —
and the engine walks the owner tree from them: nothing per node, a walk at
navigation cadence, only while the check is on or something listens.
`graphSize()` is exported from solid-js/attribution for a consumer's own
schedule. Prod is byte-identical (the bodies fold to a return).

Size: tier +165 B (the registry; cap 17.5 -> 17.60 KB), engine +632 B
(cap 29.00 -> 29.65 KB). Idle tripwire unchanged.

Co-Authored-By: Claude via Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(signals): GRAPH_GROWTH measures the reactive graph, not only the owner tree

The owner walk counted components and owned computations and missed the
leak it named in its own message: an effect created with no owner, held
alive only by the sources it reads. The walk now continues from the owner
tree into the reactive graph — each computation's dependency links
(`edges`) and the `signals` and computations they reach, and each reache... (continued)

606 of 894 branches covered (67.79%)

Branch coverage included in aggregate %.

883 of 1142 relevant lines covered (77.32%)

25.07 hits per line