coreui / coreui-pro / 35913268998

96%

main: 94%

push

github

fix(Popup): keep the page still when the panel takes focus (#1401)

* fix(Popup): keep the page still when the panel takes focus

Opening a picker whose panel mounts into body (a field inside an overflow,
transform or contain ancestor, or an explicit container) scrolled the page
to the bottom. The panel is appended at the end of the document, Floating UI
sets its position a tick later, and the entry cell received focus in
between, so the browser scrolled to where the panel still was.

Focus the entry with preventScroll: the panel ends up next to the anchor,
which is already in view. Measured in Chromium: scrollY went from 1813 to 0.

* fix(Popup): reveal the entry once the panel is positioned

preventScroll alone removed every scroll, including the ones the old
focus() did on purpose: the roll column that reopens at scrollTop 0 after
the panel was unmounted, a panel opened programmatically with the field
below the fold, and the mobile branch, which never positions a teleported
panel at all. The entry still takes focus without scrolling; once the first
position is applied (or right away when positioning is skipped) it scrolls
into view with block and inline nearest, which touches nothing when the
panel already sits by a visible field.

The three cases live in the visual suite, since none of them has a layout
without the stylesheet; each fails with preventScroll alone.

6022 of 6641 branches covered (90.68%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

11132 of 11518 relevant lines covered (96.65%)

615.0 hits per line