open-quantum-safe / liboqs / 35906216757
84%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 2452
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.372% (+0.01%) from 80.36%
35906216757

push

github

web-flow 
common: include opensslconf.h so OPENSSL_NO_STDIO is actually visible (#2576)

* common: include opensslconf.h so OPENSSL_NO_STDIO is actually visible

common.h checks #ifdef OPENSSL_NO_STDIO to select between two
OQS_OPENSSL_GUARD() implementations, but never includes any OpenSSL
header itself. OPENSSL_NO_STDIO is only ever defined by
<openssl/opensslconf.h> (pulled in transitively by <openssl/crypto.h>
and others).

In every real consumer of this macro (aes_ossl.c, sha2_ossl.c,
rand_nist.c, ossl_sha3.c, ossl_sha3x4.c), oqs/oqs.h -- and therefore
this header -- is included before ../ossl_helpers.h, which is what
actually pulls in <openssl/crypto.h>. So by the time the preprocessor
reaches this #ifdef, OPENSSL_NO_STDIO has never been defined yet
regardless of how the linked OpenSSL was actually built: the check is
structurally a no-op, always selecting the non-no-stdio branch.

Including <openssl/opensslconf.h> directly here, guarded on
OQS_USE_OPENSSL, makes OPENSSL_NO_STDIO reflect the real build
configuration of the linked OpenSSL regardless of what a given
translation units include order happens to be.

Fixes #2057

Signed-off-by: Johnson Ajibi <ajibijohnson@gmail.com>

* common: move OQS_OPENSSL_GUARD to ossl_helpers.h

The previous fix for #2057 added an <openssl/opensslconf.h> include to
common.h to make its #ifdef OPENSSL_NO_STDIO check actually see the
macro. As baentsch pointed out, that is the wrong place: common.h is
part of liboqs public API surface and must not gain a hard OpenSSL
header dependency, since liboqs is buildable without OpenSSL at all.

Move OQS_OPENSSL_GUARD (and the OPENSSL_NO_STDIO check it depends on)
into ossl_helpers.h instead. That header is internal, already
OQS_USE_OPENSSL-only, and already includes <openssl/crypto.h> (which
pulls in opensslconf.h) before anything in the file references
OPENSSL_NO_STDIO -- so the ordering bug is fixed by construction,
without adding any new OpenSSL dependency to a public header.

co... (continued)

176289 of 219341 relevant lines covered (80.37%)

3502729.68 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
75.22
-2.65% src/kem/hqc/pqc-hqc_hqc-5_ref/vector.c
2
64.81
-0.46% src/sig/ml_dsa/mldsa-native_ml-dsa-44_ref/mldsa/src/sign.c
1
96.72
-1.64% src/kem/classic_mceliece/pqclean_mceliece348864_clean/encrypt.c
1
95.92
-2.04% src/kem/classic_mceliece/pqclean_mceliece460896_avx2/encrypt.c
1
96.44
-0.09% src/sig/falcon/pqclean_falcon-1024_aarch64/keygen.c
1
52.24
-1.49% src/sig/falcon/pqclean_falcon-1024_aarch64/vrfy.c
1
95.55
-0.09% src/sig/falcon/pqclean_falcon-512_clean/keygen.c
1
33.33
-4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-44_aarch64/mldsa/src/rounding.h
1
96.49
-1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-44_x86_64/mldsa/src/packing.c
1
94.74
-1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-65_aarch64/mldsa/src/packing.c
1
96.49
1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/packing.c
1
96.3
-1.85% src/sig/uov/pqov_ov_Is_neon/ov.c
Jobs
ID Job ID Ran Files Coverage
1 arm64-distbuild - 35906216757.1 1495
57.74
GitHub Action Run
2 x64-generic - 35906216757.2 1073
82.7
GitHub Action Run
3 x64-distbuild - 35906216757.3 2027
54.06
GitHub Action Run
Source Files on build 35906216757