hydrologie / xhydro / 35878301961

91%

push

github

add coords, fix Raven times (#458)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] If changes affect the GIS, Raven Modelling, HYDROTEL Modelling,
Extremes.jl or Use Case Example notebooks, they have been re-run
(ReadTheDocs will not update these).
- [x] If text has changed, ``make initialize-translations`` /
``make-translations.bat`` has been run and translations have been
updated.
- [x] (If applicable) Tests have been added.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Added a `add_coords` argument to the `run` function of hydrological
models to control whether or not coordinates should be added to the
datasets.
* Added a `time_as_starting` argument to the `run` function of Raven to
modify the period-ending outputs to be period-starting instead.
* Exposed `_model_utils.py`, since its functions are actually callable
by themselves.

### Does this PR introduce a breaking change?

* No.

### Other information:

31 of 35 new or added lines in 6 files covered. (88.57%)

2872 of 3170 relevant lines covered (90.6%)

4.39 hits per line