MapColonies / shigola / cd44d2f6f

57%

master: 44%

Build Type

push

github

Committed by web-flow

Commit Message

fix(config): say what type a key takes when its value will not parse (MAPCO-11617) (#34)

* fix(env): name the value and the wanted type in parse errors (MAPCO-11617)

ErrType formatted its value with %t, the boolean verb, so every wrong-typed
config value read "type %!t(int64=1) could not be converted". It now names
the value and what it should have been: `1 (int64) is not a boolean (true
or false)`.

A string that does not parse as a bool, int, uint or float now returns the
same error instead of strconv's text, which named a Go function rather
than the config.

The two ErrType sites in dict.go know their key, so they return
dict.ErrKeyType like every other branch in that file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(config): say what type a key takes when its value will not parse (MAPCO-11617)

A value the TOML lexer cannot read, like `serve_layer_collections = xx`,
is rejected before any type reaches our code, so the error could only say
it "expected value". toml.ParseError records the key, though, and the key
names a field of Config. Parse now walks Config through its toml tags to
that field and appends what it takes:

  Near line 3 (last key parsed 'maps.serve_layer_collections'):
  expected value but found "xx" instead
  (maps.serve_layer_collections takes a boolean, true or false)

The hint is read off the field's kind, so it cannot go stale as keys are
added. It is given only for kinds that are unambiguous: env.URL is a
struct written as a string and env.Dict is a table of anything, so
structs, maps and arrays of tables stay silent, as does any type that
decodes itself outside env. The result wraps the ParseError.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(config): tidy the type hint after review (MAPCO-11617)

Name the singular/plural hint pair instead of indexing a [2]string, share
the pointer-stripping loop, and describe every int, uint and float width
rather than only the ones Config uses t... (continued)

Coverage Stats

114 of 123 new or added lines in 5 files covered. (92.68%)

2 existing lines in 1 file now uncovered.

6019 of 10606 relevant lines covered (56.75%)

121.34 hits per line