MapColonies / shigola / 04b10a2b8

57%

master: 44%

Build Type

push

github

Committed by web-flow

Commit Message

feat(log): emit records in the MapColonies JSON format (MAPCO-11544) (#32)

* feat(log): emit records in the MapColonies JSON format (MAPCO-11544)

Records now have js-logger's shape — integer-millisecond time, pino's
lowercase level label, and pid, hostname, version and rev at the top level
rather than under a shigola group — so one collector and one set of queries
work across shigola and the JS services.

An error logged under err is serialised as pino does it, {type, message,
stack}, with the log site's stack at ERROR and above. The debug.Stack() added
to every ERROR record, error or not, is gone.

log.New is now the one place those fields are produced; cmd/shigola and
cmd/shigola_lambda both install it. Lambda previously installed nothing and
logged slog's default text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(log): stop the variadic helpers panicking on a non-string argument

Error, Warn, Info and Debug passed args[0].(string) to slog as the message
and every argument as an attribute, so log.Error(err) panicked — as every
error path in Lambda's init did — and every other call repeated its message
as attribute keys. They now format their operands as Println does.

Every helper, formatted ones included, now attaches the first error among its
arguments under err, which is how an error reaches the err property without
its call site being rewritten. A disabled level returns before formatting.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cmd): report a failed command as a log record (MAPCO-11544)

main printed the error Execute returned to stdout as plain text, and cobra
printed it again on stderr as "Error: ...", so the most common fatal CLI
error — a config that will not load — was the one line not in the log
format. It is now logged through internal/log, and a logger is installed
before Execute so a failure ahead of initConfig, such as an unknown flag, is a
record too.

Co-Authored-By: Claude Opus 5.5 <norep... (continued)

Coverage Stats

99 of 120 new or added lines in 5 files covered. (82.5%)

6 existing lines in 1 file now uncovered.

5898 of 10502 relevant lines covered (56.16%)

122.34 hits per line