coreui / coreui-pro / 35862211796

95%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(Calendar): keep the view and the picked range across clicks and setConfig (#1394)

* fix(Calendar): keep the view and the picked range across clicks and setConfig

- A click on day 29 to 31 in a second panel shifted the month off the
  clicked date, so May 31 became April 31, that is May 1, and the next
  press of the next-month button skipped a month.
- setConfig() rebuilt every date and the view from the configuration,
  which the calendar never writes a pick back to. The date range picker
  calls it with only selectEndDate when a field gains focus, so focusing
  the end field wiped the range the user had just picked, sent the view
  back to the configured month and dropped a months or years view back to
  days. Now only the dates named in the call are rebuilt, the view month
  follows the date the call names rather than a stale configured one,
  and the view is reset only when selectionType changes.
- A pick of the first week row set the calendar date to the start of the
  week, usually in the previous month, so the next-month button showed
  the same month again. Picking a week row no longer moves the view.

convertToDateObject() returns null rather than an Invalid Date for a
string it cannot read, so a bad week bound no longer poisons the grid.

* build(bundlewatch): raise the unminified JS budgets by 1 KB

Keeping the calendar view and the picked range across clicks and
setConfig adds 197 to 201 bytes to the unminified bundles (gzip -9,
measured against v6-dev), which the room left by the previous raise did
not cover. The minified bundles grow by 120 to 153 bytes and still fit
their budgets, which stay where they are.

Coverage Stats

6018 of 6645 branches covered (90.56%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

11137 of 11531 relevant lines covered (96.58%)

647.61 hits per line