hyperledger-labs / fabric-smart-client / 35841090586

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(view): report a missing endpoint resolver instead of dereferencing it (#1879)

* fix(view): report a missing endpoint resolver instead of dereferencing it

newSession called resolver.GetName() and resolve returned resolver.GetId()
on the value returned by EndpointService.Resolver without checking it for
nil, while the sibling newSessionByID guards that same value. Since
EndpointService is an interface, an implementation may return a nil
resolver alongside a nil error, which is what the existing guard
anticipates.

GetSession consults resolve through its identity iterator while looking
for an existing session, so that call site panics before newSession is
reached. Guard both: newSession reports the party it could not resolve,
and resolve wraps ErrInvalidIdentity, matching the IsNone case above it.

Fixes #1878

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

10 of 10 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

27561 of 31981 relevant lines covered (86.18%)

2730.91 hits per line