solidjs / solid / 35831436745

74%

main: 89%

push

github

fix(signals): a cleanup that disposes its root runs exactly once (#3601) (#3606)

`runDisposal` iterated `node._disposal` / `_pendingDisposal` and nulled
it only after the loop. A cleanup that calls the root's `dispose()`
re-enters the node through the death walk (#3592's parked-frame drain)
and ran the whole list a second time. The same shape latched a throwing
cleanup: the list survived the throw and every later flush re-threw it.

Detach the list before running it, as `_cleanup` already does (#2813).
Mirror in the server `disposeOwner`.

Fixes #3601

Co-authored-by: Claude via Cursor <noreply@cursor.com>

585 of 856 branches covered (68.34%)

Branch coverage included in aggregate %.

867 of 1114 relevant lines covered (77.83%)

19.85 hits per line