solidjs / solid / 35830541128

74%

main: 89%

push

github

fix(solid): hybrid memo/signal handoff waits for the landing and opens no pending window (#3574 shape) (#3605)

The memo-shaped hybrid takeover in hydrateSignalLike (#2993) —
createMemo(async function*…, { ssrSource: "hybrid" }) and function-form
createSignal — flipped its gate at CREATION: the client generator re-ran
immediately as a fresh flight, ahead of the still-pending server answer,
superseding the server flight (the #3499 shape #3551 fixed for stores)
and reading pending from creation until the client's first yield. Over a
streamed <Loading> that reproduced #3574 exactly: the boundary resuming
to claim its fragment saw a pending source, selected its fallback, and
tried to claim it against the resolved server content —
`Hydration key miss for "210"`, the `_hk=2000` span replaced instead of
claimed, and `shown = ["loading","true:0","loading","true:0","true:10"]`.

The handoff now follows the store's rules 1–5 on the store's helpers:
adoptedAnswerStream lands the pending answer as a one-yield stream whose
second pull flips the gate (rule 1 — the server flight is not superseded
before it lands); the handoff run is wrapFirstYield over the client
generator with the node's `prev` — the adopted answer — as the quiet
value for steps 0 and 1 (rule 5; the duplicate lands as an equal write;
wrapFirstYield gains an optional `quiet` parameter, one helper for both
adapters); a rejected server answer is adopted and transfers authority
without a handoff run (rule 3); a dependency change before the landing
supersedes the answer (rule 4). Sync and promise-shaped hybrid computes
keep their creation flip and adopt-the-serialized-value semantics
unchanged.

Tests: web server→artifact→hydrate pair for the memo-shaped #3574 fixture
(createMemo and createSignal(fn), generator and promise sources, streamed
and loaded), and a solid handoff spec pinning rules 1–5 for both
families (client generator starts counted before/after the landing,
fresh boundary + isPending durin... (continued)

585 of 856 branches covered (68.34%)

Branch coverage included in aggregate %.

33 of 34 new or added lines in 1 file covered. (97.06%)

867 of 1114 relevant lines covered (77.83%)

19.9 hits per line