ruby-grape / grape / 35829957554

100%

master: 100%

Pull #2983

github

Spec untested branches in error messages, middleware, the router and DSL readers

Covers branches no spec reached:

- `Exceptions::Base#compose_message` skipping a step whose translation
  is blank (a step missing from the locale was already covered).
- `Middleware::Error` answering its failsafe response on an env without
  `rack.errors`, which Rack::Lint rejects and rack-test cannot send.
- `Middleware::Formatter` passing through a request that announces a
  body but carries none: no `rack.input` (optional since Rack 3.1), or
  a chunked input that reads empty.
- `Router::BaseRoute` with a route naming a param twice: its captures
  cannot be read off the union match, so it has none of its own, in the
  router's union or in any bucket, and Mustermann answers every
  position.
- `Router::RouteBuckets#segment_key` with a path that has fewer
  segments than the position the buckets split on: it names no bucket,
  and the request goes to the fallback.
- `Grape::Testing`'s `reset_before_each` on an endpoint class no hook
  was ever registered on. The suite's `after` hook only reached that
  depending on example order.
- `ParamsScope` validators run on their own, outside the request's
  ParamScopeTracker, for a `given` scope within an array param and for
  an array param at the root (`Validators::Base#validate_elements!`):
  nothing is tracked, and what is missing is still reported.
- `optional :all, using:` with a field whose options are nil: the field
  is left out, as `requires :none` already does.
- `Types::ArrayCoercer` built strict, for an Array member type in
  `types:` with `coerce_with`: the custom method's result is only
  type-checked, so a blank String is not coerced into an empty Array.
- `Types::CustomTypeCoercer` with a callable given as `type:` alongside
  `coerce_with`, as its docs describe: the callable checks the coerced
  value.
- `Types::MultipleTypeCoercer` and `Types::VariantCollectionCoercer`
  with `coerce_with` given as an object r... (continued)

1485 of 1507 branches covered (98.54%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 8 files covered. (100.0%)

4330 of 4330 relevant lines covered (100.0%)

29054.98 hits per line