kobotoolbox / kpi / 35820724591

83%

master: 76%

push

github

fix(accounts): stop resending confirmation emails at headless login DEV-2435 (#7624)

### 📣 Summary
Signing in with an unverified account through the new authentication API
no longer sends another activation email automatically. A new link is
only sent when it is explicitly asked for.

### 📖 Description
Until now, every attempt to log in with an account whose email address
had not been confirmed quietly triggered a fresh activation email. Users
who tried a few times ended up with several near-identical messages in
their inbox and no clue which link was the live one.

The redesigned sign-in screen (React SPA + `allauth` headless) replaces
that with a button for requesting a new link,
so the automatic send is no longer needed and has been removed. Creating
an account still sends the activation email as before, and the current
sign-in page is unchanged; it keeps sending a fresh link on login until
it is retired.

`AccountAdapter.should_send_confirmation_mail()` now returns `False` for
headless requests unless the send is part of a signup.

10254 of 13584 branches covered (75.49%)

4 of 5 new or added lines in 1 file covered. (80.0%)

32790 of 39530 relevant lines covered (82.95%)

5.51 hits per line