solidjs / solid / 35795913484

74%

main: 89%

push

github

fix(signals): a parked frame dies with its owner — root disposal mid-action drains it (#3561) (#3592)

Disposing a root while an action was pending permanently skipped the
cleanups of a memo branch's previous frame. `recompute` under a held
transaction parks the previous pass's children and `onCleanup`s as
zombies on `_pendingFirstChild` / `_pendingDisposal` (#3404) until the
commit retires them. The disposal walk only enumerates `_firstChild`, so
it flagged the memo REACTIVE_DISPOSED without reaching the parked frame,
and `commitPendingNode`'s drain then returned on that flag. The cleanups
never ran; the zombies stayed subscribed and re-ran inside the torn-down
tree once a later transaction drained the zombie heap.

Owner disposal is death (#3024): `disposeChildren`'s `self` path now
drains the parked frame (zombie mode) before setting the flag. Gated on
`self && !zombie` — a rerun's `disposeChildren(el)` leaves the frame
rendering until commit (#3404 pins stay green). Covers the createRoot
disposer, `owner.dispose()`, parent disposal, nested parked owners, and
`unobserved()` dormancy. The drained frame unwinds in #3572 order:
children first, later registrations before earlier.

Minified core floor 26,130 -> 26,193 (+63 B); ceiling 26_160 -> 26_230.
Brotli scenarios all within caps (core floor 9,706 -> 9,716 B).

Co-authored-by: Claude via Cursor <noreply@cursor.com>

555 of 824 branches covered (67.35%)

Branch coverage included in aggregate %.

827 of 1073 relevant lines covered (77.07%)

17.52 hits per line