decentraland / builder / 35760964968

57%

push

github

chore: bump decentraland-transactions to 3.3.0 (#3509)

* chore: bump decentraland-transactions to 3.3.0

3.3.0 registers the off-chain marketplace V3 on both mainnets, which the
pinned version had only on the testnets. The Builder takes the address it
grants minter rights to from decentraland-dapps, and the two resolve the
same installed copy, so the grant moves to V3 on mainnet with the bump
alone. That is the point: the grant has to name the contract the trade is
signed against, or the mint reverts.

The enumeration of what a collection may already hold grows with it, so a
collection listed through an older version keeps reading as on sale and
its rights stay revocable.

One test asserted the mainnet fallback to V2, which no longer happens, and
a second described the enumeration's catch branch as reachable there. Every
version is now deployed on every chain the Builder uses, so that branch
runs nowhere; what the case still covers is a grant made before the newest
version shipped, and it says so.

* chore: move decentraland-dapps off the snapshot pin onto 29.9.0

Master pinned the snapshot build 29.8.1-20260917145350.commit-98dbac9 to
pick up the legacy credits chip fix before it was released. 29.9.0 is out
and contains that commit, so the pin can go back to a released range.

It also carries the decentraland-transactions 3.3.0 bump this branch makes
directly, which is what resolves OffChainMarketplaceV3 on Ethereum and
Polygon mainnet. Keeping both means the app and the library agree on the
marketplace addresses no matter which one resolves the contract.

* test: run the signing and grant invariant on mainnet too

The check that Builder signs against the same marketplace it grants minter
rights to only ran on Amoy, while the bump's whole effect is on mainnet.
It passes there unchanged, because both sides call one resolver and cannot
disagree by construction, so this is coverage for the version of that
resolver which is gated on chain rather than a ... (continued)

2636 of 5727 branches covered (46.03%)

Branch coverage included in aggregate %.

7629 of 12288 relevant lines covered (62.08%)

37.21 hits per line