Ouranosinc / xclim / 35754402123

91%

push

github

Put history back on DataArray outputs as `xclim_description` - Fix units metadata handling (#2431)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Puts a `history` on DataArray outputs, as before. Dataset outputs only
get one global history, their variables do not get one. DataArray
outputs do not get a "merge" of inputs' history, only the xclim part.
* Moves the history -editing methods to `_MetadataFormatter`
* Adds a new `base_variables` attribute to all indicator outputs,
listing xclim variables names of the inputs.

### Does this PR introduce a breaking change?
No.


### Other information:
@RondeauG @juliettelavoie and anyone else. This currently adds a
space-separated list (common in cf) of input variables, using the
indicator's argument names. This means it's `da` for generic indicator,
but also means it's `tas` even if the input was named
`température_de_lair_à_2m`.

Is this sufficient ? I also thought of doing something like :
`{arg_name}={input name}`. So a generic could look like `da=tas` and a
funky one like my example : `tas=température_de_lair_à_2m`. Opinions ?

41 of 41 new or added lines in 4 files covered. (100.0%)

8117 of 8964 relevant lines covered (90.55%)

7.63 hits per line