pantsbuild / pants / 35745096071

93%

push

github

Skip PATH entries that return PermissionDenied during binary lookup (#23681)

`path_metadata` already treats `NotFound` and `NotADirectory` as absent
so `system_binary` / PATH lookup can continue. A search-path entry that
returns `EPERM`/`EACCES` (sandbox, unreadable dir) still crashed with
`IntrinsicError`.

Map `ErrorKind::PermissionDenied` to `Ok(None)` next to the existing
`NotADirectory` arm. A chmod-000 PATH directory is skipped and a later
entry still matches.

Fixes pantsbuild/pants#23366

Tested: regression in `system_binaries_test.py`
(`test_find_binary_permission_denied_path_entry`).

---

**LLM assistance notice**
([policy](https://www.pantsbuild.org/dev/docs/contributions#llm-assistance-notice)):
the `PermissionDenied` mapping and the chmod regression test were
drafted with LLM assistance. I compared them to the `#23327`
`NotADirectory` path in `posixfs.rs` / `system_binaries.py` and kept the
hunk to that one error kind.

14 of 14 new or added lines in 1 file covered. (100.0%)

95898 of 103208 relevant lines covered (92.92%)

3.66 hits per line